jgrulich added inline comments.
INLINE COMMENTS
> teamportsettingtest.cpp:103
> + if (it.key() == QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS)) {
> + NMVariantMapList list = it_1.value().value<NMVariantMapList>();
> + NMVariantMapList list1 =
> map1.value(it_1.key()).value<NMVariantMapList>();
Why don't you skip this and just use NMVariantMapList list =
map.value(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS).value<NMVariantMapList>()?
same for the second one. You don't need to go through the map to get
"link-watchers" property.
REVISION DETAIL
https://phabricator.kde.org/D17342
To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
