cullmann added a comment.
One issue I have with the auto-tests: With and without any of these changes here locally the vimode_keys test fails. FAIL! : KeysTest::MacroTests() Compared values are not the same Actual (kate_document->text()): "completionMacro completionRepeatLastChange completionRep" Expected (expected_text) : "completionMacro completionRepeatLastChange completionRepeatLastChange" Loc: [/home/cullmann/kde/src/frameworks/ktexteditor/autotests/src/vimode/keys.cpp(1512)] REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann