elvisangelaccio added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:907-909
> +    dialog->show();
> +    dialog->raise();
> +    dialog->activateWindow();

I think we should just use `dialog->open()` here. I see you've copied these 3 
lines from Dolphin, but we should also fix it there (the rename dialog should 
really be modal).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, michaelh, 
ngraham, bruns

Reply via email to