aacid added a comment.
In D17620#378110 <https://phabricator.kde.org/D17620#378110>, @yurchor wrote: > Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obvious that this change will never happen. > > Just a side note: the protected method is useless and can be removed without loss of any functionality because all known setHelp()'s are commented now with hopeless messages like "TODO: port to kf5". Yuri, you keep doing aggressive comments like this, your patches are interesting, but honestly i don't know if for me it's worthwhile helping you, if every so often you complain about how much everything is broken when it is not. Of course the method is not useless, this method is trivially usable by just having a class that inherits from KConfigDialog like Okular and i'm sure lots of other apps do. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17620 To: yurchor, #frameworks Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
