chinmoyr added inline comments.
INLINE COMMENTS
> copyjob.cpp:419
> + // TODO: this is done only for local files, but we could use the
> UDSEntry to do this portably
> + // ... assuming all kioslaves set permissions correctly
> + if (fileInfo.exists() && !fileInfo.isWritable()) {
For file permissions, 'file:' and 'trash:' use the result of QT_LSTAT,
'archive:' makes use of stat, 'sftp:' uses sftp_lstat, and smb sets UDS_ACCESS
to 0500. These are the kioslaves(I found) which KDE ships and set UDS_ACCESS
entry. I think using UDSEntry can be considered here.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17632
To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns
