bruns added a comment.
I think this is ok now, but I would like to have one +1 from any other frameworks developer. INLINE COMMENTS > formatstrings.h:21 > +#ifndef KFILEMETADATA_FORMATSTRINGS_H > +#define KFILEMETADATA_FORMATSTRINGS_H > This is a private headers, and thus should have a _p infix. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
