davidedmundson added a comment.
Why do we need the code in both CopyJob and File_unix? INLINE COMMENTS > file_unix.cpp:425 > + #elif defined(Q_OS_MAC) > + ssize_t vallen = listxattr(_src.data(), key, NULL, 0, 0, 0); > + #elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD) you need to check vallen for error returns. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns
