cochise updated this revision to Diff 48731. cochise added a comment.
Tests refactored, but no multiplatform. Other small fixes. The tests aren't a big mess anymore, and some groundwork for multiplatform tests are in place, but as I don't have a non linux system, I can't finish this work. Include checks moved to ConfigureChecks.cmake. Warning about destination FS not supporting xattrs demoted to debug. As listxattr function returns 0 if the source FS don't support xattrs, no ENOTSUP check is made at this stage. Nesting reduced using a switch for listlen. After some tests, I think this is the option with better redability. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=48586&id=48731 BRANCH xattr-copy-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES autotests/jobtest.cpp autotests/jobtest.h src/core/ConfigureChecks.cmake src/core/config-kiocore.h.cmake src/core/copyjob.cpp src/ioslaves/file/CMakeLists.txt To: cochise, dfaure Cc: dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns