dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS
> knewfilemenutest.cpp:170 > + dialog->accept(); > + path = ""; > + } else { path.clear() or path = QString() would be better; but ok this is only a unittest ;) REPOSITORY R241 KIO BRANCH fix-test-and-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D17911 To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns