cullmann accepted this revision. cullmann added a comment.
I think the current state can go in. Here with and without this patch two tests fail: The following tests FAILED: 24 - kateindenttest_testCppstyle (Failed) 67 - vimode_emulatedcommandbar (Failed) (perhaps due to Qt 5.12) REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars