mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land.
The KSharedDataCache change is definitely correct. I've not done much with the kdelibs migrator but I agree with the logic and the implementation. Have you tried building some of the other frameworks or Plasma after implementing this patch? That's the only real risk I can think of. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18137 To: aacid, mpyne Cc: mpyne, kde-frameworks-devel, michaelh, ngraham, bruns