loh.tar updated this revision to Diff 49636. loh.tar added a comment.
- Fix typo of member vars - Add missing setView(m_view) - Remove FIXME hint about timer, however would a comment for me nice - Use QString() Things which could be improved or not - The up/down buttons are a little bit small, have tried to give them the hight (and width) of the hight of the other buttons, but without success. Ideas? - There is no tooltip on the spinbox and Goto button - The spinbox will not adjust its size and value boundaries when you paste text while its shown. Try: - New file->show bar - Paste 10+ lines - Spinbox keep size of one digit and can't be set to an other value as 1 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18164?vs=49243&id=49636 REVISION DETAIL https://phabricator.kde.org/D18164 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs/katedialogs.h To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars