D16894: [ECM] use a macro to add compiler flags conditionally

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> ECMAddCompilerFlag.cmake:108
> +            check_cxx_compiler_flag(${flag} ${HASFLAG})
> +            if({${HASFLAG}})
> +                set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${flag}" 
> PARENT_SCOPE)

if(HASFLAG)

you're testing the result, not the string

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, 
#build_system, michaelh, ngraham, bruns