dhaumann added a comment.
In general I am ok eith this. Although it's a tiny bit less transparent to the user. INLINE COMMENTS > spellcheckdialog.cpp:74 > { > - spellcheck(m_view->cursorPosition()); > + if (m_view->selection()) { > + spellcheckSelection(); I don't like the fact that the function says "spellcheckFromCursor, and then internally does something different. Can this be improved by having the logic somewhere else? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18663 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars