harald marked 2 inline comments as done. harald added a comment.
In D18864#408305 <https://phabricator.kde.org/D18864#408305>, @dhaumann wrote: > Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed. Hi Dominik, thanks so much for the review :) I took the default flatbuffers file from their docs as that has most of the keywords/attributes. Their documentation is Apache licensed, so I guess this should be OK? REPOSITORY R216 Syntax Highlighting BRANCH flatbuffers (branched from master) REVISION DETAIL https://phabricator.kde.org/D18864 To: harald, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars
