dhaumann added inline comments. INLINE COMMENTS
> repository.h:176 > + */ > + QVector<Definition> definitionsForFileName(const QString &fileName) > const; > + As I understand, this currently is unsorted. Wouldn't it make sense to sort the returned vector by priority? This information is also missing currently in the API documentation: I had to read the code to understand whether the Definitions in the QVector are sorted or not. Same for definitionsForMimeType(). Any comments? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars
