nicolasfella accepted this revision. nicolasfella added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > CMakeLists.txt:3 > +find_package(KF5Notifications COMPONENTS) > +if (NOT KF5KIO_FOUND OR NOT KF5Notifications_FOUND) > + return() Maybe move the check to the parent CMakeLists.txt and include fileitemactionplugin conditionally? REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D19111 To: apol, #dolphin, #frameworks, nicolasfella Cc: ngraham, kde-frameworks-devel, michaelh, bruns
