hallas added inline comments.

INLINE COMMENTS

> filecopyjob.cpp:495
> +        } else if (job == d->m_chmodJob) {
> +            if (d->m_delJob) {
> +                d->m_delJob->kill(Quietly);

Should we also set d->m_chmodJob to nullptr here, just like the m_putJob 
handling branch?

> filecopyjob.cpp:500
> +        } else if (job == d->m_delJob) {
> +            if (d->m_chmodJob) {
> +                d->m_chmodJob->kill(Quietly);

Should we also set d->m_delJob to nullptr here, just like the m_putJob handling 
branch?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to