bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:70
> That will then require to load and write the property map twice when 
> properties only specific to some tagging formats need to be written, see e.g. 
> Ape and Vorbis tags in D18604 <https://phabricator.kde.org/D18604>. I would 
> like to avoid this.

So **iff** the rating is updated at the same time as another property, taglib 
has to adjust some in-memory structure twice. Obviously, for most formats this 
poses no problem, but for Ape/Vorbis it does?

Also, this no longer applies when you use the specific tag types for Ape/Ogg.

Writing to disk only happens when calling `file->save()`...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

Reply via email to