astippich added a comment.
There are currently larger refactorings ongoing (D19287 <https://phabricator.kde.org/D19287>, D18826 <https://phabricator.kde.org/D18826>), could you please wait for them and rebase afterwards? INLINE COMMENTS > externalextractor.cpp:151 > + const auto lstKeys = propertiesObject.keys(); > + for(const auto &key : lstKeys) { > if (key == QStringLiteral("typeInfo")) { missing space: for ( > extractorplugin.cpp:140 > list.reserve(contactStrings.count()); > - foreach(const QString& contactName, contactStrings) { > + for(const QString& contactName : qAsConst(contactStrings)) { > list << contactName.trimmed(); missing space: for ( REPOSITORY R286 KFileMetaData BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19442 To: mlaurent, dfaure, apol Cc: astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, abrahams
