chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > copyjob.cpp:1909 > const QString srcDir = QFileInfo(_src).absolutePath(); > - QTemporaryFile tmpFile(srcDir + QLatin1String("kio_XXXXXX")); > + QTemporaryFile > tmpFile(QDir(srcDir).filePath(QLatin1String("kio_XXXXXX"))); > const bool openOk = tmpFile.open(); IMO QDir isn't required here. QLatin1String("/kio_xxxxxx") is sufficient. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns