dfaure created this revision. dfaure added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY If we ever end up in a situation where the generated .pc file is actually used by cmake's pkg_check_modules, then we need the includedir and libdir variables; pkg_check_modules ignores the Makefile-like Libs and Cflags lines of the .pc file. Context: craft adds a cmake buildsystem for sqlite3, which is then found using pkgconfig in akonadi. TEST PLAN Filipe Azevedo is doing all the testing, I'm just providing patches :) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 AFFECTED FILES modules/ECMGeneratePkgConfigFile.cmake To: dfaure, apol Cc: kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns