dfaure created this revision. dfaure added reviewers: kossebau, apol, cgiboudeaux. Herald added projects: Frameworks, Build System. dfaure requested review of this revision.
REVISION SUMMARY Note that the first test had a comment "without optional arguments" so I removed the INCLUDE_INSTALL_DIR variable to test what happens by default. The other tests still pass an absolute path there (which is unusual in practice, and breaks the idea of using ${prefix}). TEST PLAN `ctest -R PkgConfig` passes REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19538 AFFECTED FILES modules/ECMGeneratePkgConfigFile.cmake tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc tests/ECMGeneratePkgConfigFile/KF5CoreAddons2.pc tests/ECMGeneratePkgConfigFile/KF5CoreAddons3.pc tests/ECMGeneratePkgConfigFile/run_test.cmake.config To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, fazevedo, michaelh, ngraham, bruns