aacid added a comment.
In D7732#425077 <https://phabricator.kde.org/D7732#425077>, @davidedmundson wrote: > > I'm not sure changing the codec for all kauth stuff is the best > > I did it in just my one helper initially, but in review it was suggested to make it global as it affects everyone. I'm content with either as long as I'm not deadlocked between them. Ok, then get whoever told you yo do it for all to review this ;) INLINE COMMENTS > kauthactionreply.h:195 > + As locale is not inherited, the auth helper will have the text codec > explicitly set > + to use UTF-8. > + it should either say "unix only" here or have move the code outside the ifdef, i really don't know what's best, guess it's better if we play it safe and make it unix only? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns
