habacker marked an inline comment as done. habacker added inline comments. INLINE COMMENTS
> tbaumgart wrote in khtmlview.cpp:3134 > Why don't you pass a reference to the QPrinter object here? Because api dealing with QPrinter always use a pointer. void QWebView::print(QPrinter *) void QPrintPreviewDialog::paintRequested(QPrinter *printer) QPrintPreviewDialog(QPrinter *printer, QWidget *parent = nullptr, Qt::WindowFlags flags = Qt::WindowFlags() QPrintDialog(QPrinter * printer, QWidget * parent = 0) QPageSetupDialog(QPrinter *printer, QWidget *parent) QPrintPreviewWidget(QPrinter *printer, QWidget *parent, Qt::WindowFlags flags) REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker Cc: tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns
