cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
In D19532#426005 <https://phabricator.kde.org/D19532#426005>, @vkrause wrote: > In D19532#425432 <https://phabricator.kde.org/D19532#425432>, @cullmann wrote: > > > Ok with that. > > Volker, ok, too? > > I think the if(...isLoaded) removal is a diff artifact, that was never in the original code bug just in the first try here. > > > Yep, replacing the assert certainly makes sense. This would assume though that the caller of initalContext() expects a nullptr return value already, which I guess is the case if this doesn't crash somewhere else now :) Hmm, actually that part of the diff is not needed, either. No caller is able to handle nullptrs, but that just doesn't happen. I would like to have that change removed, then we can apply this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever, vkrause Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
