broulik created this revision. broulik added reviewers: dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision.
REVISION SUMMARY Currently, `slotReport` is called all the way at the end when in `STATE_SETTING_DIR_ATTRIBUTES`. However, `slotReport` does nothing in this state. Instead, move it to before changing away from `STATE_COPYING_FILES` so that progress is correctly reported for a final time. TEST PLAN Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. Chose a different filename and continued. Before, the job would finish without having reported any progress as the report timer never fired since that one file was copied super quickly. With this patch, the final progress is correct. The URL isn't updated in case of a rename but I bet it just needs a `m_bURLDirty` call somewhere in the conflict handler REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19585 AFFECTED FILES src/core/copyjob.cpp To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns
