bruns added a comment.

  The change, as you pushed it, was never open for review, so there was not 
even the chance to review.
  
  The new test files change the tested tag from one allowed variant to another. 
Both variants exist in the wild, and you changed the test coverage to the one 
you seemed to be more important. A good change would have increased the 
coverage.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

Reply via email to