mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
one minor nit, otherwise looks like a good improvement
INLINE COMMENTS
> katehighlight.cpp:78
> + if (schema == QLatin1String("Normal")) {
> + return QLatin1String("Default");
> + } else if (schema == QLatin1String("Solarized (light)")) {
return QStringLiteral, otherwise you allocate on every function call (also
below)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19876
To: nibags, #ktexteditor, #kate, cullmann, mwolff
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad,
domson, michaelh, ngraham, bruns, demsking, sars
