apol added inline comments.

INLINE COMMENTS

> bruns wrote in propertyinfotest.cpp:71
> This saves adding the `QVariant(...)` around each value, and avoids the 
> repeated formatting of the row name/data index. The property enum is used 
> twice in each addRow.

And instead it makes you create a weird local struct and loop to feed to QTest. 
I don't find it very convincing.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

Reply via email to