astippich accepted this revision.
astippich added a comment.
Just two small nitpicks
INLINE COMMENTS
> mimeutils.cpp:39
> + for (auto mime : extensionMimes) {
> + // check if the content is a specialized type (child) for a generic
> container, e.g.:
> + // *.mkv -> [ application/matroska ]
That reads a little bit confusing. I think it is more clear to write something
like "Check if extension based mime type is a specialized..."?
> mimeutils.h:33
> +KFILEMETADATA_EXPORT
> +QMimeType strictMimeType(const QString& filePath, const QMimeDatabase& db);
> +
Please add documentation with "since" tag
REPOSITORY
R286 KFileMetaData
BRANCH
submit_mime
REVISION DETAIL
https://phabricator.kde.org/D20045
To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
