astippich accepted this revision.
astippich added inline comments.
INLINE COMMENTS
> extractorcoveragetest.cpp:50
> + m_knownFiles = {
> + { "test.aif", "audio/x-aifc"},
> + { "test.ape", "audio/x-ape"},
Is it really audio/x-aifc? Taglibextractor the never actually got called. Looks
like we should also wire the new helper funciton into the extractor tests, so
that we make sure they support the right mimetype
REPOSITORY
R286 KFileMetaData
BRANCH
extractor_coverage
REVISION DETAIL
https://phabricator.kde.org/D20046
To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
