ngraham added a comment.
This doesn't build: /home/nate/kde/src/kio/src/widgets/kurlcombobox.cpp: In member function ‘void KUrlComboBox::setUrls(const QStringList&, KUrlComboBox::OverLoadResolving, KUrlComboBox::OldUrlPolicy)’: /home/nate/kde/src/kio/src/widgets/kurlcombobox.cpp:197:17: error: declaration of ‘QStringList urls’ shadows a parameter QStringList urls; ^~~~ INLINE COMMENTS > kurlnavigator.cpp:55 > #include <QMimeData> > +#include <QLineEdit> > The existing list is not 100% sorted alphabetically, but let's assume alphabetical sorting for new entries, so this should go right below `#include <QLabel>` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns