mpyne accepted this revision. mpyne added a comment.
+1 to @aacid's comment about relicensing. The code is good and easy to review. Only comment I had was to think about using a warning or error when unable to parse the file. I think that the `ID_LIKE` handling could be done by using `setVar(QString)` and then splitting the result on space instead of stripping quotes first and letting `KShell` figure it out, but I concur that anyone trying to use special characters in `ID_LIKE` is just asking for trouble anyways. However the warning/error decision goes, I support landing the change as long as any copyright holders to the KInfoCenter source agree to the change. INLINE COMMENTS > kosrelease.cpp:126 > + // stripping difficult. > + continue; > + } Would this situation not warrant a warning or debug entry to be printed to console? Or are you concerned this might be too noisy? REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol, mpyne Cc: aacid, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns
