meven added a comment.
In D20096#440443 <https://phabricator.kde.org/D20096#440443>, @bruns wrote: > I think the regular stat and statx implementations should be merged. This requires a little bit of refactoring, but avoids a lot of code duplication. I thought about it, but the two structs have quite some differences, so it would require to introduce an intermediary stat struct, which is fine for me. And then introduce a STAT like macro to wrap either calling statx or QL_STAT and mixing and matching stat/statx into the new struct. Do you agree with this course ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns
