meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS
> bruns wrote in file.cpp:878 > You should start with a more sensible size for lowerLimit, e.g. 256, maybe > more - the scope is local, i.e. any excess size is hardly relevant, and > allocating 1 and 256 byte cost the same. > > lowerLimit is not used below, I think you don't have to name it. > > You should use (buff.stx_size + 1), as the size is without trailing null byte. I have 256 as I'd rather allocate the minimal size without adding cost here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
