ahmedbilal added a comment.
In D20312#444802 <https://phabricator.kde.org/D20312#444802>, @svuorela wrote: > I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. > > My systems have several users named "Sune Vuorela" @svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there seems to be no use case where it would be used besides showing avatar for PDF's authors. Whats your comment on it. @tsdgeos in Okular room suggest not to show any avatar in case if there are more than 1 users with exact same Real Name. But, I think we should skip it as there are many scenarios when the avatar being shown is not true to the reality. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh, ngraham, bruns
