dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
Is the makeURL function still used, or should it be removed now? INLINE COMMENTS > urlinfo.h:39 > + */ > + UrlInfo(QString path) > + : line(0), column(0) const QString & And what if it's a URL? At this point this string is pathOrUrl. > urlinfo.h:77 > + */ > + url = QUrl::fromUserInput(path, QDir::currentPath(), > QUrl::AssumeLocalFile); > + I'm not sure about AssumeLocalFile, in the context of kde-open. This is about opening existing files, not creating new files. So it should be removed. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, elvisangelaccio Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
