hallas added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kprocesslist.cpp:69
> With the QSharedDataPointer you can delete this method.
> 
> The point of the shareddatapointer is that when you copy KProcessInfo you 
> don't copy all the members, we just increase the internal ref-count

If I delete the method I get compilation errors, since users of this class 
doesn't know the definition of `KProcessInfoPrivate` - so the method needs to 
be here, it could just be a whole lot simpler ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

Reply via email to