sh-zam added inline comments.
INLINE COMMENTS
> apol wrote in ECMAndroidDeployQt.cmake:43
> This looks quite awful. Why do you prefer using regex to string(FIND)? It
> could be something like
> `string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific.
Because `string (FIND ..)` doesn't work if `libc++.so` isn't added first to
`CMAKE_CXX_STANDARD_LIBRARIES`
In my case this is the original value of `CMAKE_CXX_STANDARD_LIBRARIES`:
-latomic -lm
"/home/sh_zam/Android/Sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libunwind.a"
"/home/sh_zam/Android/Sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_shared.so"
and the value written to `stl` file is the same thing as above, which down the
line causes `androidqtdeploy` to fail.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20558
To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns
