cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Given we have no actions and some more proper documentation, I am in favor of
this.
I would remove the two asserts here:
Q_ASSERT(startLine >= 0);
Q_ASSERT(startLine < lines());
if (startLine < 0 || startLine >= lines()) {
return KTextEditor::Range::invalid();
}
I think range checking + invalid range as result is good enough.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D20606
To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
