dhaumann added a comment.
Please fix the API getters: in the KDE/Qt world, getters never start with 'get': just use availableProdiles() etc. Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile(). Could you provide an updated patch? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns
