hallas added a comment.
In D20209#450100 <https://phabricator.kde.org/D20209#450100>, @dfaure wrote: > Urgh. Indeed. And looking around I find many inline virtuals in apparently public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff (though maybe some of these don't have d pointers at all...) > > About KBookmarkOwner, the lack of an explicit constructor is a problem too (apps wouldn't instanciate the d pointer). I just added TODO KF6 comments, for the next person in your position: https://commits.kde.org/kbookmarks/746ecc8db9a04e4d47adc62b0aa03733ca8ecdf8 > > Meanwhile we have to find another way. Would my idea of adding methods to KBookmarkMenu work out? @dfaure - I have now implemented the functionality in `KBookmarkMenu` instead, so now there should be no ABI breakage :D Let me know what you think. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
