cfeck requested changes to this revision.
cfeck added a comment.

  Before we can support both dark and light themes we need to investigate the 
KSyntaxHighlighting issue found by Friedrich.
  
  Later we could request a light or dark theme depending on the lightness of 
the QPalette entry, but I would suggest to use View instead of Window, because 
window backgrounds are gray with some themes, while view backgrounds usually 
have more contrast (either darker or brighter than gray).

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

Reply via email to