ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Code looks sane now. But the UI needs polish. Putting it in the advanced page feels awkward to me, and even on that page, its location isn't right. It feels arbitrary, disconnected from the rest of the UI. I feel like it might sit better on the main page, to the left of the Advanced Permissions button. Alternatively, if it has to stay on the advanced page, it needs to feel better integrated with the rest of the layout. Adding #VDG <https://phabricator.kde.org/tag/vdg/> for more commentary. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino, #vdg Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
