hallas added a comment.
In D20209#456311 <https://phabricator.kde.org/D20209#456311>, @aacid wrote: > In D20209#456213 <https://phabricator.kde.org/D20209#456213>, @hallas wrote: > > > In D20209#455579 <https://phabricator.kde.org/D20209#455579>, @aacid wrote: > > > > > @hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/ > > > > > > Hi @aacid - I can't reproduce the test failure locally! I am running Gentoo Linux with Qt 5.11.3 - do you have any idea what could be wrong? Can you reproduce the issue? > > > It may have to do with how much "extra" stuff is there on your system. You can try running the docker infrastructure (needs some space+internet downloads), this should make it easier to reproduce > https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine > > It works here too but i don't have all the frameworks as of master, maybe that's the issue and a framework this depends on creates the issues? Ok I found the problem and have pushed a fix here: D20860 <https://phabricator.kde.org/D20860> Thanks for notifying about the build failure! REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
