svuorela added a comment.

  After reading the code a bit, I wonder
  
  - can't some of the parsing code be made testable (and tests added)
    - This likely also requires to get rid of the global static.
  - rather than poll /proc/mounts every second, I was wondering if one of the 
filesystem notification things (QFileSystemWatcher, KDirWatch) could tell when 
to re-parse it

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20938

To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns
Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to