nibags created this revision. nibags added reviewers: KTextEditor, Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision.
REVISION SUMMARY Currently, when selecting a language in the "Highlighting" menu, the "Mode" menu stops working. This happens because, the Modes don't apply if `m_hlSetByUser` is true (if the user has chosen a Highlight in the menu). This is swelling and I think it's better to change it. Now when selecting a Mode, the "Highlighting" menu is also updated (but, when choosing an item in the Highlighting menu, the "Mode" menus don't change). REPOSITORY R39 KTextEditor BRANCH fix-mode-highlight-menu REVISION DETAIL https://phabricator.kde.org/D20959 AFFECTED FILES src/document/katedocument.cpp To: nibags, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann