ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
Needs a rebase on master and the @since strings adjusted, but otherwise looks good to me. INLINE COMMENTS > global.h:248 > ERR_PASSWD_SERVER = KJob::UserDefinedError + 72, ///< returned by > SlaveBase::openPasswordDialogV2, @since 5.24 > - ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73 ///< used by > Slave::createSlave, @since 5.30 > + ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > + 5.59 now > global.h:250 > + > + ERR_PRIVILEGE_NOT_REQUIRED = KJob::UserDefinedError + 74 ///< used by > file ioslave, @since 5.50 > }; 5.59 now REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14464 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns
