ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Sorry, but this doesn't compile:
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp: In member function
‘bool KFileWidgetPrivate::matchFilter(const QString&, const QString&, bool)’:
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:25: error: ‘p’
declared as reference but not initialized
for (const QString &p, patterns) {
^
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:36: error:
expected ‘;’ before ‘)’ token
for (const QString &p, patterns) {
^
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:36: error:
expected primary-expression before ‘)’ token
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:36: error:
expected ‘;’ before ‘)’ token
Needs to be `for (const QString &p : patterns) {`
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D21249
To: jglogowski, #frameworks, ngraham
Cc: ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns
